* [PATCH] v2writable: fix assertions around reindexing
@ 2019-05-25 19:19 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-05-25 19:19 UTC (permalink / raw)
To: meta
Fix a misspelling and ensure line context is printed by
`die' by leaving out the final '\n'. Also, `delete' was
pointless.
---
lib/PublicInbox/V2Writable.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index a6f044a..cd08acd 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -851,7 +851,7 @@ sub index_prepare {
my $regen_max = 0;
my $head = $self->{-inbox}->{ref_head} || 'refs/heads/master';
for (my $i = $epoch_max; $i >= 0; $i--) {
- die "already indexing!\n" if $self->{index_pipe};
+ die 'BUG: already indexing!' if $self->{reindex_pipe};
my $git_dir = git_dir_n($self, $i);
-d $git_dir or next; # missing parts are fine
my $git = PublicInbox::Git->new($git_dir);
@@ -967,7 +967,7 @@ sub index_sync {
# work backwards through history
for (my $i = $epoch_max; $i >= 0; $i--) {
my $git_dir = git_dir_n($self, $i);
- die "already reindexing!\n" if delete $self->{reindex_pipe};
+ die 'BUG: already reindexing!' if $self->{reindex_pipe};
-d $git_dir or next; # missing parts are fine
fill_alternates($self, $i);
my $git = PublicInbox::Git->new($git_dir);
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-25 19:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-25 19:19 [PATCH] v2writable: fix assertions around reindexing Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).