From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A084E1F462 for ; Sat, 25 May 2019 19:19:47 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] v2writable: fix assertions around reindexing Date: Sat, 25 May 2019 19:19:47 +0000 Message-Id: <20190525191947.6849-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Fix a misspelling and ensure line context is printed by `die' by leaving out the final '\n'. Also, `delete' was pointless. --- lib/PublicInbox/V2Writable.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index a6f044a..cd08acd 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -851,7 +851,7 @@ sub index_prepare { my $regen_max = 0; my $head = $self->{-inbox}->{ref_head} || 'refs/heads/master'; for (my $i = $epoch_max; $i >= 0; $i--) { - die "already indexing!\n" if $self->{index_pipe}; + die 'BUG: already indexing!' if $self->{reindex_pipe}; my $git_dir = git_dir_n($self, $i); -d $git_dir or next; # missing parts are fine my $git = PublicInbox::Git->new($git_dir); @@ -967,7 +967,7 @@ sub index_sync { # work backwards through history for (my $i = $epoch_max; $i >= 0; $i--) { my $git_dir = git_dir_n($self, $i); - die "already reindexing!\n" if delete $self->{reindex_pipe}; + die 'BUG: already reindexing!' if $self->{reindex_pipe}; -d $git_dir or next; # missing parts are fine fill_alternates($self, $i); my $git = PublicInbox::Git->new($git_dir); -- EW