* [PATCH] msgmap: remove double negative
@ 2019-05-25 9:40 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-05-25 9:40 UTC (permalink / raw)
To: meta
I have never not found double negatives to be confusing...
---
lib/PublicInbox/Msgmap.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Msgmap.pm b/lib/PublicInbox/Msgmap.pm
index d474bad..0035c9e 100644
--- a/lib/PublicInbox/Msgmap.pm
+++ b/lib/PublicInbox/Msgmap.pm
@@ -130,7 +130,7 @@ INSERT OR IGNORE INTO msgmap (mid) VALUES (?)
return if $sth->execute($mid) == 0;
my $num = $dbh->last_insert_id(undef, undef, 'msgmap', 'num');
- $self->num_highwater($num) unless !defined($num);
+ $self->num_highwater($num) if defined($num);
$num;
}
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-25 9:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-25 9:40 [PATCH] msgmap: remove double negative Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).