From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] msgmap: remove double negative
Date: Sat, 25 May 2019 09:40:22 +0000 [thread overview]
Message-ID: <20190525094022.22685-1-e@80x24.org> (raw)
I have never not found double negatives to be confusing...
---
lib/PublicInbox/Msgmap.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Msgmap.pm b/lib/PublicInbox/Msgmap.pm
index d474bad..0035c9e 100644
--- a/lib/PublicInbox/Msgmap.pm
+++ b/lib/PublicInbox/Msgmap.pm
@@ -130,7 +130,7 @@ INSERT OR IGNORE INTO msgmap (mid) VALUES (?)
return if $sth->execute($mid) == 0;
my $num = $dbh->last_insert_id(undef, undef, 'msgmap', 'num');
- $self->num_highwater($num) unless !defined($num);
+ $self->num_highwater($num) if defined($num);
$num;
}
--
EW
reply other threads:[~2019-05-25 9:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190525094022.22685-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).