user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] httpd: get rid of Deflater warning
@ 2019-05-05 20:42 Eric Wong
  2019-05-05 21:28 ` default PSGI middlewares (was: httpd: get rid of Deflater warning) Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2019-05-05 20:42 UTC (permalink / raw)
  To: meta

Deflating responses may be done by the reverse proxy (e.g. varnish
or nginx), so the warning for it could be invalid.
---
 examples/public-inbox.psgi | 2 --
 script/public-inbox-httpd  | 2 --
 2 files changed, 4 deletions(-)

diff --git a/examples/public-inbox.psgi b/examples/public-inbox.psgi
index 8886d7f..0b8500d 100644
--- a/examples/public-inbox.psgi
+++ b/examples/public-inbox.psgi
@@ -25,8 +25,6 @@ builder {
 				application/atom+xml
 				)]
 	};
-	$@ and warn
-"Plack::Middleware::Deflater missing, bandwidth will be wasted\n";
 
 	# Enable to ensure redirects and Atom feed URLs are generated
 	# properly when running behind a reverse proxy server which
diff --git a/script/public-inbox-httpd b/script/public-inbox-httpd
index 47e38ec..56551ed 100755
--- a/script/public-inbox-httpd
+++ b/script/public-inbox-httpd
@@ -32,8 +32,6 @@ my $refresh = sub {
 						application/atom+xml
 						)]
 			};
-			$@ and warn
-"Plack::Middleware::Deflater missing, bandwidth will be wasted\n";
 
 			eval { enable 'ReverseProxy' };
 			$@ and warn
-- 
EW


^ permalink raw reply	[flat|nested] 2+ messages in thread

* default PSGI middlewares (was: httpd: get rid of Deflater warning)
  2019-05-05 20:42 [PATCH] httpd: get rid of Deflater warning Eric Wong
@ 2019-05-05 21:28 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2019-05-05 21:28 UTC (permalink / raw)
  To: meta

Now, the ReverseProxy middleware may be invalid (or become less
valid) in the future as well: TLS may come to NNTP and we might
as well support HTTPS natively while we're at it.

I can't drop middlewares by default since it would break
existing installations which don't rely on a .psgi config;
but there can be options to disable it... (not that I'm a
fan of adding more options).

Keeping ReverseProxy in the default middleware stack along with
the existing warning would probably be the right thing to do.
Worst case somebody malicious could do is change logging of
IP addresses.  Maybe the warning could be silenced if listening
on 0.0.0.0:{443,80}

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-05 20:42 [PATCH] httpd: get rid of Deflater warning Eric Wong
2019-05-05 21:28 ` default PSGI middlewares (was: httpd: get rid of Deflater warning) Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox