From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id AE90F20248 for ; Thu, 18 Apr 2019 23:35:26 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] view: show "(no subject)" consistently in HTML Date: Thu, 18 Apr 2019 23:35:26 +0000 Message-Id: <20190418233526.12114-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Empty subjects ("") and undefined Subjects: are now both displayed as "(no subject)" for now. --- lib/PublicInbox/SearchView.pm | 1 + lib/PublicInbox/View.pm | 3 +++ 2 files changed, 4 insertions(+) diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm index 7ef6b07..3b3afde 100644 --- a/lib/PublicInbox/SearchView.pm +++ b/lib/PublicInbox/SearchView.pm @@ -120,6 +120,7 @@ sub mset_summary { } my $date = PublicInbox::View::fmt_ts($smsg->ds); my $mid = PublicInbox::Hval->new_msgid($smsg->mid)->{href}; + $s = '(no subject)' if $s eq ''; $$res .= qq{$rank. }. $s . "\n"; $$res .= "$pfx - by $f @ $date UTC [$pct%]\n\n"; diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index f94daaf..62bdf0a 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -213,6 +213,7 @@ sub index_entry { my $irt; my $obfs_ibx = $ctx->{-obfs_ibx}; + $subj = '(no subject)' if $subj eq ''; my $rv = "* "; $subj = ''.ascii_html($subj).''; obfuscate_addrs($obfs_ibx, $subj) if $obfs_ibx; @@ -729,6 +730,7 @@ sub thread_skel { my $subj = $hdr->header('Subject'); defined $subj or $subj = ''; + $subj = '(no subject)' if $subj eq ''; $ctx->{prev_subj} = [ split(/ /, $srch->subject_normalized($subj)) ]; $ctx->{cur} = $mid; $ctx->{prev_attr} = ''; @@ -1039,6 +1041,7 @@ sub acc_topic { if ($x) { $subj = $x->subject; $subj = $srch->subject_normalized($subj); + $subj = '(no subject)' if $subj eq ''; $ds = $x->ds; if ($level == 0) { $topic = [ $ds, 1, { $subj => $mid }, $subj ]; -- EW