user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] viewvcs: check for premature EOF from git-cat-file
@ 2019-04-02  0:45 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-04-02  0:45 UTC (permalink / raw)
  To: meta

Not entirely sure what is causing this, but it appears to
be causing infinite loops when attempting to display certain

Fortunately, the fair scheduling of public-inbox-httpd prevented
this from becoming a real problem aside from increasing CPU
 lib/PublicInbox/ | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index b90cd8c..962dc66 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -62,6 +62,10 @@ sub stream_large_blob ($$$$) {
 				my $ct = 'text/plain; charset=UTF-8';
 				return [200, ['Content-Type', $ct, @cl] ];
+			if ($r == 0) {
+				warn "premature EOF on $oid $$logref\n";
+				return html_page($ctx, 500, $logref);
+			}
 			undef; # bref keeps growing

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02  0:45 [PATCH] viewvcs: check for premature EOF from git-cat-file Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone