user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] config: ignore missing config files
@ 2019-03-08 22:54 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-03-08 22:54 UTC (permalink / raw)
  To: meta

There's no reason for us to have git-config(1) warn users when a
config file is entirely missing.
---
 lib/PublicInbox/Config.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index da443e5..2ff266f 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -147,6 +147,7 @@ sub default_file {
 sub git_config_dump {
 	my ($file) = @_;
 	my (%section_seen, @section_order);
+	return {} unless -e $file;
 	my @cmd = (qw/git config/, "--file=$file", '-l');
 	my $cmd = join(' ', @cmd);
 	my $fh = popen_rd(\@cmd) or die "popen_rd failed for $file: $!\n";
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-03-08 22:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-08 22:54 [PATCH] config: ignore missing config files Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).