From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3E82120248 for ; Wed, 27 Feb 2019 23:34:46 +0000 (UTC) Received: by mail-it1-x144.google.com with SMTP id v2so12043635ith.3 for ; Wed, 27 Feb 2019 15:34:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LTl4cMYFWG7T94i88kSYotCSQGzn1hb9dz0aZpDdZnY=; b=JI5HGUgnLLRtW9U7w5yPa65MGEEYBIyRjTRXfSW1mKNi1zaJyQaaFbGhsL3ZiCjCEe 0zx3wLZA8WmySSAJ1Ll7r/esx6n7gYTOAwYU2K99lHUeKDDvVV0ZdE2Znac/OqWkjsZn SZ1yv7JP0+OJ17ZTUTqkxxWYAHR0OiA/259Mg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LTl4cMYFWG7T94i88kSYotCSQGzn1hb9dz0aZpDdZnY=; b=eczbGlaGAG5fY0/tiBzH4eoqOT2MzG0EeXJahidsvhHOxGO2HGQf0UIN1deD7jfHsS THknKJn8GREIcOthEQV3VkP2cEA1uI+ZkGPN53s3fTfEIEzKgx9TiJzyWx9jyRDz8iLA p6aTh+pkM7rftT9IVhEa6MX+2SUw4ZDgvByBPVX+lXEJTXC7SPL9pN5TJiFGW2+A5qhQ A6CelVnj64l6c4xxu5WEZpRERVS3I8UgQi1yzBSn43F9nO0b4kcdTOKP2+rxUxbk+zYu zVaFK44C+MA/iUJemD0zcEiVKlJx1K7HjV22S7RJi0Na7TjSBYB2uFcNIjfJeZESvqFF D7nA== X-Gm-Message-State: APjAAAVw/7LEk5zquFp9tzEGSX6AqsDZmh8znuaH6RTtCtSU3R+59LeP obQwTXRH9oZadVaVssMI9HTfBA== X-Google-Smtp-Source: APXvYqwVOoZmJdJ6osglkfOW90J21re8HQbHUDs44HIGAfKxI0PJAU8KLEXrAcHBuQlSfGcl161B6Q== X-Received: by 2002:a24:1d0:: with SMTP id 199mr1072973itk.41.1551310485131; Wed, 27 Feb 2019 15:34:45 -0800 (PST) Received: from chatter.qube.local ([199.66.90.113]) by smtp.gmail.com with ESMTPSA id r17sm1916795ita.31.2019.02.27.15.34.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 15:34:44 -0800 (PST) Date: Wed, 27 Feb 2019 18:34:41 -0500 From: Konstantin Ryabitsev To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH] v2writable: fix epoch rollover on incremental imports Message-ID: <20190227233441.GB24519@chatter.qube.local> References: <20190212191116.GA8720@chatter.qube.local> <20190212192715.mtncyagjzusi3vtp@dcvr> <20190227002204.GA17917@dcvr> <20190227132604.GA24441@pure.paranoia.local> <20190227202536.uvlvggnt4bwtgx5h@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20190227202536.uvlvggnt4bwtgx5h@dcvr> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: On Wed, Feb 27, 2019 at 08:25:36PM +0000, Eric Wong wrote: >All of our internal epoch rollover calculations are done using >the estimated unpacked (and uncompressed) size of the repo. The >importer instance needs to check that unpacked size before >selecting an epoch when an epoch already has packed data. > >This bug did not impact the initial mass imports since we only >initialize the Import instance once-per-epoch and did not need >to take existing epochs into account. > >Tested manually with -mda on a local clone of LKML Ding, this got us shard 7. :) Thanks, Eric! -K