From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id EEF0D1F453 for ; Wed, 13 Feb 2019 22:56:08 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] ensure bytes::length is available to callers Date: Wed, 13 Feb 2019 22:56:08 +0000 Message-Id: <20190213225608.7704-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We were relying on Danga::Socket using the "bytes" pragma, previously. Nowadays, the "bytes" pragma is not recommended in general, but bytes::length remains acceptable for getting the byte-size of a scalar. --- lib/PublicInbox/HTTP.pm | 1 + lib/PublicInbox/View.pm | 1 + lib/PublicInbox/ViewVCS.pm | 1 + lib/PublicInbox/WWW.pm | 1 + lib/PublicInbox/WwwAttach.pm | 1 + lib/PublicInbox/WwwHighlight.pm | 1 + lib/PublicInbox/WwwText.pm | 1 + t/psgi_search.t | 1 + t/search-thr-index.t | 1 + 9 files changed, 9 insertions(+) diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index 9657b31..e73bd81 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -12,6 +12,7 @@ use strict; use warnings; use base qw(Danga::Socket); use fields qw(httpd env rbuf input_left remote_addr remote_port forward pull); +use bytes (); # only for bytes::length use Fcntl qw(:seek); use Plack::HTTPParser qw(parse_http_request); # XS or pure Perl use HTTP::Status qw(status_message); diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index e64c965..429eba8 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -6,6 +6,7 @@ package PublicInbox::View; use strict; use warnings; +use bytes (); # only for bytes::length use PublicInbox::MsgTime qw(msg_datestamp); use PublicInbox::Hval qw/ascii_html obfuscate_addrs/; use PublicInbox::Linkify; diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index f6a7694..f537451 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -16,6 +16,7 @@ package PublicInbox::ViewVCS; use strict; use warnings; +use bytes (); # only for bytes::length use PublicInbox::SolverGit; use PublicInbox::WwwStream; use PublicInbox::Linkify; diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm index 406802a..cbaf884 100644 --- a/lib/PublicInbox/WWW.pm +++ b/lib/PublicInbox/WWW.pm @@ -14,6 +14,7 @@ package PublicInbox::WWW; use 5.008; use strict; use warnings; +use bytes (); # only for bytes::length use PublicInbox::Config; use PublicInbox::Hval; use URI::Escape qw(uri_unescape); diff --git a/lib/PublicInbox/WwwAttach.pm b/lib/PublicInbox/WwwAttach.pm index b1504f5..d690ce4 100644 --- a/lib/PublicInbox/WwwAttach.pm +++ b/lib/PublicInbox/WwwAttach.pm @@ -5,6 +5,7 @@ package PublicInbox::WwwAttach; # internal package use strict; use warnings; +use bytes (); # only for bytes::length use Email::MIME::ContentType qw(parse_content_type); use PublicInbox::MIME; use PublicInbox::MsgIter; diff --git a/lib/PublicInbox/WwwHighlight.pm b/lib/PublicInbox/WwwHighlight.pm index 09fc48a..0191640 100644 --- a/lib/PublicInbox/WwwHighlight.pm +++ b/lib/PublicInbox/WwwHighlight.pm @@ -21,6 +21,7 @@ package PublicInbox::WwwHighlight; use strict; use warnings; +use bytes (); # only for bytes::length use HTTP::Status qw(status_message); use parent qw(PublicInbox::HlMod); diff --git a/lib/PublicInbox/WwwText.pm b/lib/PublicInbox/WwwText.pm index adadc37..f42f359 100644 --- a/lib/PublicInbox/WwwText.pm +++ b/lib/PublicInbox/WwwText.pm @@ -5,6 +5,7 @@ package PublicInbox::WwwText; use strict; use warnings; +use bytes (); # only for bytes::length use PublicInbox::Linkify; use PublicInbox::WwwStream; use PublicInbox::Hval qw(ascii_html); diff --git a/t/psgi_search.t b/t/psgi_search.t index a057a99..da6cc68 100644 --- a/t/psgi_search.t +++ b/t/psgi_search.t @@ -7,6 +7,7 @@ use File::Temp qw/tempdir/; use Email::MIME; use PublicInbox::Config; use PublicInbox::WWW; +use bytes (); # only for bytes::length my @mods = qw(PublicInbox::SearchIdx HTTP::Request::Common Plack::Test URI::Escape Plack::Builder); foreach my $mod (@mods) { diff --git a/t/search-thr-index.t b/t/search-thr-index.t index ab6d1b0..ed3e4e7 100644 --- a/t/search-thr-index.t +++ b/t/search-thr-index.t @@ -2,6 +2,7 @@ # License: AGPL-3.0+ use strict; use warnings; +use bytes (); # only for bytes::length use Test::More; use File::Temp qw/tempdir/; use PublicInbox::MID qw(mids); -- EW