user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] http: cleanup partial-write handling on readonly values
@ 2019-02-06 10:33 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-02-06 10:33 UTC (permalink / raw)
  To: meta

Don't bother assigning to $_[1]; just let Danga::Socket
do its thing since $_[1] should be out-of-scope soon.
---
 lib/PublicInbox/HTTP.pm | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index bc10814..9657b31 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -318,11 +318,9 @@ sub more ($$) {
 		if (defined $n) {
 			my $nlen = length($_[1]) - $n;
 			return 1 if $nlen == 0; # all done!
-			eval { $_[1] = substr($_[1], $n, $nlen) };
-			if ($@) { # modification of read-only value:
-				return $self->write(substr($_[1], $n, $nlen));
-			}
-			# fall through to normal write:
+
+			# Danga::Socket::write queues the unwritten substring:
+			return $self->write(substr($_[1], $n, $nlen));
 		}
 	}
 	$self->write($_[1]);
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-06 10:33 [PATCH] http: cleanup partial-write handling on readonly values Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox