From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E19BB21421 for ; Sun, 27 Jan 2019 04:03:43 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 08/14] view: swap CRLF for LF in HTML output Date: Sun, 27 Jan 2019 04:03:35 +0000 Message-Id: <20190127040341.26107-9-e@80x24.org> In-Reply-To: <20190127040341.26107-1-e@80x24.org> References: <20190127040341.26107-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It makes no difference to browsers aside from saving a few bytes; and this means we won't have to worry about extra '%0D' showing up in links to solver. --- lib/PublicInbox/View.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 41a45b0..5aaa72b 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -557,6 +557,10 @@ sub add_text_body { return attach_link($upfx, $ct, $p, $fn) unless defined $s; + # makes no difference to browsers, and don't screw up filename + # link generation in diffs with the extra '%0D' + $s =~ s/\r\n/\n/sg; + my ($diff, $spfx); if ($s =~ /^(?:diff|---|\+{3}) /ms) { $diff = []; -- EW