From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 08/14] view: swap CRLF for LF in HTML output
Date: Sun, 27 Jan 2019 04:03:35 +0000 [thread overview]
Message-ID: <20190127040341.26107-9-e@80x24.org> (raw)
In-Reply-To: <20190127040341.26107-1-e@80x24.org>
It makes no difference to browsers aside from saving a few
bytes; and this means we won't have to worry about extra
'%0D' showing up in links to solver.
---
lib/PublicInbox/View.pm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 41a45b0..5aaa72b 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -557,6 +557,10 @@ sub add_text_body {
return attach_link($upfx, $ct, $p, $fn) unless defined $s;
+ # makes no difference to browsers, and don't screw up filename
+ # link generation in diffs with the extra '%0D'
+ $s =~ s/\r\n/\n/sg;
+
my ($diff, $spfx);
if ($s =~ /^(?:diff|---|\+{3}) /ms) {
$diff = [];
--
EW
next prev parent reply other threads:[~2019-01-27 4:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 4:03 [PATCH 00/14] convert solver to use pi-httpd.async Eric Wong
2019-01-27 4:03 ` [PATCH 01/14] httpd/async: remove needless sysread wrapper Eric Wong
2019-01-27 4:03 ` [PATCH 02/14] qspawn: implement psgi_return and use it for githttpbackend Eric Wong
2019-01-27 4:03 ` [PATCH 03/14] qspawn|getlinebody: support streaming filters Eric Wong
2019-01-27 4:03 ` [PATCH 04/14] qspawn|httpd/async: improve and fix out-of-date comments Eric Wong
2019-01-27 4:03 ` [PATCH 05/14] httpd/async: stop running command if client disconnects Eric Wong
2019-01-27 4:03 ` [PATCH 06/14] qspawn: implement psgi_qx Eric Wong
2019-01-27 4:03 ` [PATCH 07/14] t/qspawn.t: psgi_qx stderr test Eric Wong
2019-01-27 4:03 ` Eric Wong [this message]
2019-01-27 4:03 ` [PATCH 09/14] solver: rewrite to use Qspawn->psgi_qx and pi-httpd.async Eric Wong
2019-01-27 4:03 ` [PATCH 10/14] solver: hold patches in temporary directory Eric Wong
2019-01-27 4:03 ` [PATCH 11/14] solver: reduce "git apply" invocations Eric Wong
2019-01-27 4:03 ` [PATCH 12/14] qspawn: decode $? for user-friendliness Eric Wong
2019-01-27 4:03 ` [PATCH 13/14] viewvcs: do not show final error message twice Eric Wong
2019-01-27 4:03 ` [PATCH 14/14] solver: crank up max patches to 9999 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127040341.26107-9-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).