From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2BB5B1F454 for ; Fri, 18 Jan 2019 20:07:06 +0000 (UTC) Received: by mail-it1-x144.google.com with SMTP id h65so7423992ith.3 for ; Fri, 18 Jan 2019 12:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bltjhyZRUuDubcV6lNidp8gte2BpxwhbDeVIOlzPlaI=; b=FMHfgc+zBT7JazgcUg4V0XjRoZ5e9ywKJ5k0F8GyqdcSFNLS/ywBNcKwktwurwWDtN nqoa/DmIu8XbZbGaKpSiMwBI7eCB+XCQSRONTFGwrUunN7SL2nSGBOHhu7PGmx2ybXwM +6edyfm+Zke+su6EPkteiZlpiMzair1xu5Czw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=bltjhyZRUuDubcV6lNidp8gte2BpxwhbDeVIOlzPlaI=; b=bEhbw0svsROyR78+qUDWWTPjg7twUzNYKQlKHub4gKUGtP8fX2uHwU1Xw2bOxz6lxt SEvm+ODE/0b2cpsa4d8xi+Q43kx1EZPMj02X8HabTDmEJ8n1Vokweo1B7eRoZS1BP8Ry tcE7ed+apRrKDSqVE9QJ1AoRKOa7MkdHckxHQjwg0YA9vcdSKKHs/yEtot2WShLuRRPc PFeSGfrM0lZDhgND591SNSVhEWJenroGKEs+XGCcViC6Fo0DIHUaWuCM49ZuBpxJTrtS CnUYym/4cIX9LOpLUMCEpcOYyW0Js2yd6dtmWy/ShjVDLB8Muftt/uE1vCXVEMkO8Ikh F6/g== X-Gm-Message-State: AJcUukdWG9bVGr18FY9RU/yROPndkj9iNiwUpmfrcuUcxY8q3p1JIg6Q kweSRaP+YoFsbYhWMUO8abVy78kGK8Aisw== X-Google-Smtp-Source: ALg8bN6hvNrljXH4E2MBR+NyFYoNd1W6RnGt254ThW+MIdCZX3qW07hMWTScIbEZSG8yTnZ7G7s7cw== X-Received: by 2002:a24:2452:: with SMTP id f79mr12580325ita.143.1547842024949; Fri, 18 Jan 2019 12:07:04 -0800 (PST) Received: from pure.paranoia.local ([198.144.156.49]) by smtp.gmail.com with ESMTPSA id 196sm2699198itu.37.2019.01.18.12.07.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Jan 2019 12:07:04 -0800 (PST) Date: Fri, 18 Jan 2019 15:07:01 -0500 From: Konstantin Ryabitsev To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH] t/git.t: avoid passing read-only value to git_unquote Message-ID: <20190118200701.GA6330@pure.paranoia.local> Mail-Followup-To: Eric Wong , meta@public-inbox.org References: <20190118172056.GB5108@pure.paranoia.local> <20190118194706.ubssl3oehd4zn7f2@whir> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190118194706.ubssl3oehd4zn7f2@whir> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: On Fri, Jan 18, 2019 at 07:47:06PM +0000, Eric Wong wrote: > > Perl: v5.16.3 > > This is Fedora? Which version? I was working on getting a > chroot setup for testing some RPM-based distros, but some of the > mirrors/tools for doing that were out-of-date. Might try > installing in QEMU... No, this is RHEL/CentOS 7. > > Git: 2.16.5 > > Tree: d66aa534a4a7506cfc5cfab49d1e09f8db8be3dd > > Thanks for the report, following should fix it. Yep, all tests pass now. Thanks! -K