From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 7114D1F597;
	Thu, 19 Jul 2018 20:44:57 +0000 (UTC)
Date: Thu, 19 Jul 2018 20:44:57 +0000
From: Eric Wong <e@80x24.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] Import.pm: Deal with potentially missing From and Sender
 headers
Message-ID: <20180719204457.mbnklcamdklhnjmr@whir>
References: <87zhyndnls.fsf@xmission.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87zhyndnls.fsf@xmission.com>
List-Id: <meta.public-inbox.org>

"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> 
> Use ||= '' to ensure that if the From or Sender header is not present
> the code sees an empty string and instead of undefined.
> 
> I had some email messages with a From field without an @ (because the
> sender was local) and without a Sender which were causing errors when
> imported.  I think this was bad enough that the email messages were
> failing to be imported.

Thanks, pushed to master as ce5af2029b6bc703f3d8cf7bb5c68732c41f210e.

I assume this is from testing against personal mail?
I haven't tried that, yet :x