From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS6315 166.70.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5A4AF208EA; Wed, 18 Jul 2018 00:32:49 +0000 (UTC) Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1ffaOe-0001oo-IP; Tue, 17 Jul 2018 18:32:48 -0600 Received: from [97.119.167.31] (helo=x220.int.ebiederm.org) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1ffaOd-0005nf-WC; Tue, 17 Jul 2018 18:32:48 -0600 From: "Eric W. Biederman" To: Eric Wong Cc: meta@public-inbox.org, "Eric W. Biederman" Date: Tue, 17 Jul 2018 19:32:01 -0500 Message-Id: <20180718003201.31740-4-ebiederm@xmission.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <87sh4hidvg.fsf@xmission.com> References: <87sh4hidvg.fsf@xmission.com> X-XM-SPF: eid=1ffaOd-0005nf-WC;;;mid=<20180718003201.31740-4-ebiederm@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.119.167.31;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19+LUrsOMZp9Uyv3oRaVETD2dkju5mH3Ig= X-SA-Exim-Connect-IP: 97.119.167.31 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: [PATCH 4/4] t/v2reindex.t: Swap the order of minmax tests so errors make sense X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) List-Id: Previously if a minmax test failed it would say it was expecting the incorrect value, which is confusing when looking into why the test fails. Signed-off-by: "Eric W. Biederman" --- t/v2reindex.t | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/v2reindex.t b/t/v2reindex.t index 5bc307f1cac1..8af30991f858 100644 --- a/t/v2reindex.t +++ b/t/v2reindex.t @@ -63,7 +63,7 @@ $im->done; ok(-d $xap, 'Xapian directories recreated'); delete $ibx->{mm}; -is_deeply($minmax, [ $ibx->mm->minmax ], 'minmax unchanged'); +is_deeply([ $ibx->mm->minmax ], $minmax, 'minmax unchanged'); ok(unlink "$mainrepo/msgmap.sqlite3", 'remove msgmap'); remove_tree($xap); @@ -77,7 +77,7 @@ ok(!-d $xap, 'Xapian directories removed again'); $im->done; ok(-d $xap, 'Xapian directories recreated'); delete $ibx->{mm}; - is_deeply($minmax, [ $ibx->mm->minmax ], 'minmax unchanged'); + is_deeply([ $ibx->mm->minmax ], $minmax, 'minmax unchanged'); } ok(unlink "$mainrepo/msgmap.sqlite3", 'remove msgmap'); @@ -92,7 +92,7 @@ ok(!-d $xap, 'Xapian directories removed again'); $im->done; ok(-d $xap, 'Xapian directories recreated'); delete $ibx->{mm}; - is_deeply($minmax, [ $ibx->mm->minmax ], 'minmax unchanged'); + is_deeply([ $ibx->mm->minmax ], $minmax, 'minmax unchanged'); } done_testing(); -- 2.17.1