[PATCH 0/2] trivial warning message improvements

[PATCH 0/2] trivial warning message improvements

[Eric Wong]

Eric Wong (2):
      searchidx: use cached local $@ copy
      watchmaildir: show $@ in warning message

 lib/PublicInbox/SearchIdx.pm    | 2 +-
 lib/PublicInbox/WatchMaildir.pm | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

[PATCH 1/2] searchidx: use cached local $@ copy

[Eric Wong]

umask should never fail and set $@, but use the cached local
to be more explicit just in case.
---
 lib/PublicInbox/SearchIdx.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index e4e3c81..fd0d320 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -620,7 +620,7 @@ sub with_umask {
 	my $rv = eval { $cb->() };
 	my $err = $@;
 	umask $old;
-	die $err if $@;
+	die $err if $err;
 	$rv;
 }
 
-- 
EW

[PATCH 2/2] watchmaildir: show $@ in warning message

[Eric Wong]

It should be helpful to know what error happened.
---
 lib/PublicInbox/WatchMaildir.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/WatchMaildir.pm b/lib/PublicInbox/WatchMaildir.pm
index 985f919..c436742 100644
--- a/lib/PublicInbox/WatchMaildir.pm
+++ b/lib/PublicInbox/WatchMaildir.pm
@@ -111,7 +111,10 @@ sub _remove_spam {
 				$im->remove($scrubbed);
 			}
 		};
-		warn "error removing spam at $path from $ibx->{name}\n" if $@;
+		if ($@) {
+			warn "error removing spam at: ", $path,
+				" from ", $ibx->{name}, ': ', $@, "\n";
+		}
 	})
 }
 
-- 
EW