From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH ssoma] extractor: do not needlessly update config file
Date: Tue, 21 Mar 2017 22:50:39 +0000 [thread overview]
Message-ID: <20170321225039.GA3206@dcvr> (raw)
In-Reply-To: <20170321211529.6957-1-e@80x24.org>
No reason to trigger excessive writes when nothing is done.
---
| 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--git a/lib/Ssoma/Extractor.pm b/lib/Ssoma/Extractor.pm
index 7e2b5d1..baf9adb 100644
--- a/lib/Ssoma/Extractor.pm
+++ b/lib/Ssoma/Extractor.pm
@@ -47,6 +47,7 @@ sub _extract {
my $lkey = "target.$target.last-imported";
my $last = $cfg->{$lkey};
+ my $last_imported = $last;
my $ref = $self->{ref};
my $tip = $git->qx_sha1("git rev-parse $ref^0");
@@ -106,7 +107,7 @@ sub _extract {
}
# update the last-imported var
- {
+ if (!defined($last_imported) || $last_imported ne $tip) {
# This state file is important, and git does not fsync it.
if (open my $st, '<', $state) {
# clobber existing backup
--
EW
prev parent reply other threads:[~2017-03-21 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 21:15 [PATCH ssoma] extractor: backup state file when updating and fsync Eric Wong
2017-03-21 22:50 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321225039.GA3206@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).