From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: escape HTML description name
Date: Tue, 14 Mar 2017 21:25:32 +0000 [thread overview]
Message-ID: <20170314212532.13343-1-e@80x24.org> (raw)
Otherwise funky filenames can cause HTML injection
vulnerabilities (hope you have JavaScript disabled!)
---
lib/PublicInbox/View.pm | 1 +
t/view.t | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 0b1ec75..9ef4712 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -438,6 +438,7 @@ sub attach_link ($$$$;$) {
}
$ret .= "[-- Attachment #$idx: ";
my $ts = "Type: $ct, Size: $size bytes";
+ $desc = ascii_html($desc);
$ret .= ($desc eq '') ? "$ts --]" : "$desc --]\n[-- $ts --]";
$ret .= "</a>\n";
}
diff --git a/t/view.t b/t/view.t
index 46fbe41..2181b5e 100644
--- a/t/view.t
+++ b/t/view.t
@@ -124,7 +124,7 @@ EOF
Email::MIME->create(
attributes => {
content_type => 'text/plain',
- filename => "foo.patch",
+ filename => "foo&.patch",
},
body => "--- a/file\n+++ b/file\n" .
"@@ -49, 7 +49,34 @@\n",
@@ -140,7 +140,7 @@ EOF
);
my $html = msg_html($mime);
- like($html, qr!.*Attachment #2: foo\.patch --!,
+ like($html, qr!.*Attachment #2: foo&(?:amp|#38);\.patch --!,
"parts split with filename");
}
--
EW
reply other threads:[~2017-03-14 21:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314212532.13343-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).