From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/4] githttpbackend: minor cleanups to improve readability
Date: Sun, 25 Dec 2016 10:36:52 +0000 [thread overview]
Message-ID: <20161225103653.8325-4-e@80x24.org> (raw)
In-Reply-To: <20161225103653.8325-1-e@80x24.org>
Fewer returns improves readability and the diffstat agrees.
---
lib/PublicInbox/GitHTTPBackend.pm | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 4ad3fd1..1fa5e30 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -225,7 +225,6 @@ sub serve_smart {
};
my $res;
my $async = $env->{'pi-httpd.async'}; # XXX unstable API
- my $io = $env->{'psgix.io'};
my $cb = sub {
my $r = $rd_hdr->() or return;
$rd_hdr = undef;
@@ -236,17 +235,16 @@ sub serve_smart {
$rpipe->close;
$end->();
}
- return $res->($r);
- }
- if ($async) {
+ $res->($r);
+ } elsif ($async) {
$fh = $res->($r);
- return $async->async_pass($io, $fh, \$buf);
+ $async->async_pass($env->{'psgix.io'}, $fh, \$buf);
+ } else { # for synchronous PSGI servers
+ require PublicInbox::GetlineBody;
+ $r->[2] = PublicInbox::GetlineBody->new($rpipe, $end,
+ $buf);
+ $res->($r);
}
-
- # for synchronous PSGI servers
- require PublicInbox::GetlineBody;
- $r->[2] = PublicInbox::GetlineBody->new($rpipe, $end, $buf);
- $res->($r);
};
sub {
($res) = @_;
--
EW
next prev parent reply other threads:[~2016-12-25 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-25 10:36 [PATCH 0/4] various cleanups around http Eric Wong
2016-12-25 10:36 ` [PATCH 1/4] githttpbackend: minor readability improvement Eric Wong
2016-12-25 10:36 ` [PATCH 2/4] githttpbackend: simplify compatibility code Eric Wong
2016-12-25 10:36 ` Eric Wong [this message]
2016-12-25 10:36 ` [PATCH 4/4] httpd/async: improve variable naming Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161225103653.8325-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).