user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/3] nntp: add test case for the "DATE" command
Date: Tue, 13 Dec 2016 03:48:13 +0000	[thread overview]
Message-ID: <20161213034815.30324-2-e@80x24.org> (raw)
In-Reply-To: <20161213034815.30324-1-e@80x24.org>

We may not always use strftime and may implement caching.
But for now, just add a test.
---
 t/nntpd.t | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/t/nntpd.t b/t/nntpd.t
index 7192d78..ad50a64 100644
--- a/t/nntpd.t
+++ b/t/nntpd.t
@@ -203,6 +203,14 @@ EOF
 		 'XHDR on invalid header returns empty');
 
 	{
+		my $t0 = time;
+		my $date = $n->date;
+		my $t1 = time;
+		ok($date >= $t0, 'valid date after start');
+		ok($date <= $t1, 'valid date before stop');
+	}
+
+	{
 		setsockopt($s, IPPROTO_TCP, TCP_NODELAY, 1);
 		syswrite($s, 'HDR List-id 1-');
 		select(undef, undef, undef, 0.15);
-- 
EW


  reply	other threads:[~2016-12-13  3:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13  3:48 [PATCH 0/3] misc minor fixups Eric Wong
2016-12-13  3:48 ` Eric Wong [this message]
2016-12-13  3:48 ` [PATCH 2/3] nntp: avoid useless use of strftime Eric Wong
2016-12-13  3:48 ` [PATCH 3/3] searchmsg: remove unused EPOCH_822 constant Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161213034815.30324-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).