From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id DB395209B3 for ; Sat, 10 Dec 2016 03:43:05 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 0/7] message threading fixes for WWW UI Date: Sat, 10 Dec 2016 03:42:58 +0000 Message-Id: <20161210034305.2654-1-e@80x24.org> List-Id: This series improves thread handling in several oddball cases. In the Xapian search indexing phase, the In-Reply-To header is always considered the last (direct) parent of a message. This is necessary in cases where a MUA specifies References in an invalid order. This is also what our View.pm display has done for generating "reply" links. Not many repos are affected by this, but "public-inbox-index --reindex" will make those consistent (there is no incompatible Xapian DB version bump). We will now prune ghosts without children before display, as they are sometimes the result of buggy (or malicious) MUAs inserting spaces or otherwise mangling References: headers. Ghosts with valid children remain shown, as they are likely to be legitimate (but lost) messages. Deploying over the next few hours, .onions first! Currently reindexing git@vger mirror: http://czquwvybam4bgbro.onion/meta Up next: http://hjrcffqmbrq6wope.onion/meta Last: (also public-inbox.org) http://ou63pmih66umazou.onion/meta Eric Wong (7): search: favor In-Reply-To over last References iff IRT exists view: favor SearchMsg for In-Reply-To over Email::MIME thread: fix comment describing its existence view: reduce indentation for skeleton generation view: skip ghosts with no direct children thread: last Reference always wins search: always sort thread results in ascending time order lib/PublicInbox/Mbox.pm | 2 +- lib/PublicInbox/Search.pm | 5 ++++ lib/PublicInbox/SearchIdx.pm | 22 ++++++++++++--- lib/PublicInbox/SearchThread.pm | 30 ++++++++++++++------ lib/PublicInbox/View.pm | 61 +++++++++++++++++++++-------------------- t/thread-cycle.t | 8 ------ 6 files changed, 76 insertions(+), 52 deletions(-) -- EW