* [PATCH] githttpbackend: error checking for input handling
@ 2016-11-26 8:55 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-11-26 8:55 UTC (permalink / raw)
To: meta
This was sloppy code, all calls need to be checked
for failure.
---
lib/PublicInbox/GitHTTPBackend.pm | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index d491479..322005b 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -273,6 +273,10 @@ sub serve_smart {
sub input_to_file {
my ($env) = @_;
my $in = IO::File->new_tmpfile;
+ unless (defined $in) {
+ err($env, "could not open temporary file: $!");
+ return;
+ }
my $input = $env->{'psgi.input'};
my $buf;
while (1) {
@@ -281,11 +285,22 @@ sub input_to_file {
err($env, "error reading input: $!");
return;
}
- last if ($r == 0);
- $in->write($buf);
+ my $off = 0;
+ while ($r > 0) {
+ my $w = syswrite($in, $buf, $r, $off);
+ if (defined $w) {
+ $r -= $w;
+ $off += $w;
+ } else {
+ err($env, "error writing temporary file: $!");
+ return;
+ }
+ }
+ }
+ unless (defined(sysseek($in, 0, SEEK_SET))) {
+ err($env, "error seeking temporary file: $!");
+ return;
}
- $in->flush;
- $in->sysseek(0, SEEK_SET);
return $in;
}
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-11-26 8:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-26 8:55 [PATCH] githttpbackend: error checking for input handling Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).