From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] githttpbackend: error checking for input handling
Date: Sat, 26 Nov 2016 08:55:24 +0000 [thread overview]
Message-ID: <20161126085524.16977-1-e@80x24.org> (raw)
This was sloppy code, all calls need to be checked
for failure.
---
lib/PublicInbox/GitHTTPBackend.pm | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index d491479..322005b 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -273,6 +273,10 @@ sub serve_smart {
sub input_to_file {
my ($env) = @_;
my $in = IO::File->new_tmpfile;
+ unless (defined $in) {
+ err($env, "could not open temporary file: $!");
+ return;
+ }
my $input = $env->{'psgi.input'};
my $buf;
while (1) {
@@ -281,11 +285,22 @@ sub input_to_file {
err($env, "error reading input: $!");
return;
}
- last if ($r == 0);
- $in->write($buf);
+ my $off = 0;
+ while ($r > 0) {
+ my $w = syswrite($in, $buf, $r, $off);
+ if (defined $w) {
+ $r -= $w;
+ $off += $w;
+ } else {
+ err($env, "error writing temporary file: $!");
+ return;
+ }
+ }
+ }
+ unless (defined(sysseek($in, 0, SEEK_SET))) {
+ err($env, "error seeking temporary file: $!");
+ return;
}
- $in->flush;
- $in->sysseek(0, SEEK_SET);
return $in;
}
--
EW
reply other threads:[~2016-11-26 8:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161126085524.16977-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).