From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] import: failed GC runs are non-fatal
Date: Sun, 16 Oct 2016 00:38:20 +0000 [thread overview]
Message-ID: <20161016003820.20810-1-e@80x24.org> (raw)
We should not completely kill a process if "git gc --auto"
errors out due to a warning or whatnot.
---
lib/PublicInbox/Import.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 611f7b1..1ac112b 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -240,7 +240,8 @@ sub done {
my $s = PublicInbox::SearchIdx->new($inbox);
$s->index_sync({ ref => $self->{ref} });
};
- run_die([@cmd, qw(gc --auto)], undef);
+
+ eval { run_die([@cmd, qw(gc --auto)], undef) };
}
my $lockfh = delete $self->{lockfh} or die "BUG: not locked: $!";
--
EW
reply other threads:[~2016-10-16 0:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161016003820.20810-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).