user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] search: gracefully handle lookup_message failure
@ 2016-08-14 10:27 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-08-14 10:27 UTC (permalink / raw)
  To: meta

We can't blindly assume a ghost even exists in the DB, as the
rules can change internally for some corner-case Message-IDs.
---
 lib/PublicInbox/Search.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index 018fcb5..1398ea4 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -245,7 +245,7 @@ sub lookup_message {
 
 sub lookup_mail { # no ghosts!
 	my ($self, $mid) = @_;
-	my $smsg = lookup_message($self, $mid);
+	my $smsg = lookup_message($self, $mid) or return;
 	PublicInbox::SearchMsg->load_doc($smsg->{doc});
 }
 
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-14 10:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-14 10:27 [PATCH] search: gracefully handle lookup_message failure Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).