user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] httpd/async: do not attempt future writes on closed sockets
Date: Sat,  9 Jul 2016 04:51:36 +0000	[thread overview]
Message-ID: <20160709045137.7314-2-e@80x24.org> (raw)
In-Reply-To: <20160709045137.7314-1-e@80x24.org>

Danga::Socket::close does not clear the write_buf_size field,
so it's conceivable we could attempt to queue up data and
callbacks we can never flush out.
---
 lib/PublicInbox/HTTPD/Async.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/HTTPD/Async.pm b/lib/PublicInbox/HTTPD/Async.pm
index a936d9b..880cf02 100644
--- a/lib/PublicInbox/HTTPD/Async.pm
+++ b/lib/PublicInbox/HTTPD/Async.pm
@@ -41,6 +41,7 @@ sub async_pass {
 		my $r = sysread($self->{sock}, $$bref, 8192);
 		if ($r) {
 			$fh->write($$bref);
+			return if $io->{closed};
 			if ($io->{write_buf_size}) {
 				$self->watch_read(0);
 				$io->write($restart_read); # D::S::write
-- 
EW


  reply	other threads:[~2016-07-09  4:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-09  4:51 [PATCH 0/2] httpd/async race fixes Eric Wong
2016-07-09  4:51 ` Eric Wong [this message]
2016-07-09  4:51 ` [PATCH 2/2] httpd/async: reinstate D::S timer usage for cleanup Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160709045137.7314-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).