From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/1] http: drop extra newline in error message
Date: Fri, 8 Jul 2016 18:20:44 +0000 [thread overview]
Message-ID: <20160708182044.GA24300@dcvr.yhbt.net> (raw)
In-Reply-To: <20160707201212.32316-1-e@80x24.org>
We already add the extra newline when we call print.
---
lib/PublicInbox/HTTP.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 17f8930..fa34b44 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -335,7 +335,7 @@ sub write_err {
my ($self, $len) = @_;
my $err = $self->{httpd}->{env}->{'psgi.errors'};
my $msg = $! || '(zero write)';
- $msg .= " ($len bytes remaining)\n" if defined $len;
+ $msg .= " ($len bytes remaining)" if defined $len;
$err->print("error buffering to input: $msg\n");
quit($self, 500);
}
--
EW
prev parent reply other threads:[~2016-07-08 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 20:12 [PATCH] http: additional info for write failures Eric Wong
2016-07-08 18:20 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708182044.GA24300@dcvr.yhbt.net \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).