user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] address: filter out domain from address-as-name idents
Date: Fri,  1 Jul 2016 06:15:12 +0000	[thread overview]
Message-ID: <20160701061512.30061-1-e@80x24.org> (raw)

It seems common for address entries to end up as:
	"foo@example" <foo@example>

Avoid needlessly displaying the domain name in that case.
---
 lib/PublicInbox/Address.pm | 4 +++-
 t/address.t                | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Address.pm b/lib/PublicInbox/Address.pm
index cd5fbfb..e17d0b5 100644
--- a/lib/PublicInbox/Address.pm
+++ b/lib/PublicInbox/Address.pm
@@ -16,7 +16,9 @@ sub names {
 		my $e = $1;
 		s/\A['"\s]*//;
 		s/['"\s]*\z//;
-		$_ =~ /\S/ ? $_ : $e;
+		$e = $_ =~ /\S/ ? $_ : $e;
+		$e =~ s/\@\S+\z//;
+		$e;
 	} split(/\@+[\w\.\-]+>?\s*(?:,\s*|\z)/, $_[0]);
 }
 
diff --git a/t/address.t b/t/address.t
index c488a8e..3191fed 100644
--- a/t/address.t
+++ b/t/address.t
@@ -17,5 +17,7 @@ my @names = PublicInbox::Address::names(
 is_deeply(['User', 'e', 'John A. Doe', 'x'], \@names,
 	'name extraction works as expected');
 
+@names = PublicInbox::Address::names('"user@example.com" <user@example.com>');
+is_deeply(['user'], \@names, 'address-as-name extraction works as expected');
 
 done_testing;
-- 
EW


                 reply	other threads:[~2016-07-01  6:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160701061512.30061-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).