From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: move per-message anchor to top in conversation view
Date: Thu, 30 Jun 2016 18:53:14 +0000 [thread overview]
Message-ID: <20160630185314.2333-1-e@80x24.org> (raw)
This fixes the '^' (up) link in the $INBOX/new.html endpoint
for search-less displays.
---
lib/PublicInbox/View.pm | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 8487c2a..11d8dd5 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -125,9 +125,10 @@ sub index_entry {
my $root_anchor = $ctx->{root_anchor} || '';
my $irt = in_reply_to($hdr);
- my $rv = '<b>'.ascii_html($subj).'</b>';
- $rv = "<u\nid=u>$rv</u>" if $root_anchor eq $id_m;
- $rv .= "\n";
+ my $rv = "<a\nhref=#e$id\nid=m$id>*</a> ";
+ $subj = '<b>'.ascii_html($subj).'</b>';
+ $subj = "<u\nid=u>$subj</u>" if $root_anchor eq $id_m;
+ $rv .= $subj . "\n";
$rv .= _th_index_lite($mid_raw, $irt, $id, $ctx);
my @tocc;
foreach my $f (qw(To Cc)) {
@@ -241,8 +242,7 @@ sub _th_index_lite {
$rv .= $pad . $mapping->{$nn->messageid}->[1];
}
}
- $rv .= "<a\nhref=#e$id\nid=m$id>_</a> ";
- $rv .= "<a\nhref=#r$id>$s_s, $s_c; $ctx->{s_nr}</a>\n";
+ $rv .= $pad ."<a\nhref=#r$id>$s_s, $s_c; $ctx->{s_nr}</a>\n";
}
sub walk_thread {
--
EW
reply other threads:[~2016-06-30 18:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630185314.2333-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).