git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Carlo Arenas <carenas@gmail.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Beat Bolli" <dev+git@drbeat.li>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] grep: under --debug, show whether PCRE JIT is enabled
Date: Tue, 27 Aug 2019 12:43:00 -0700	[thread overview]
Message-ID: <xmqqzhju2y4b.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPUEspj4BJLjXorUXMiZnFtNcmhym_2QL5GUqeaGaCoxk=zjtw@mail.gmail.com> (Carlo Arenas's message of "Mon, 26 Aug 2019 09:36:38 -0700")

Carlo Arenas <carenas@gmail.com> writes:

>> > ... but
>> > ab/pcre-jit-fixes and UTF-8 validation are likely to make that more
>> > difficult (even if it is a mostly self inflicted wound AFAIK)
>> ...
>  for example 685668faaa (grep: stop using a custom JIT stack with PCRE
> v1, 2019-07-26) adds 2 regressions as discussed in [1]
>
> * git grep -P will now throw an error if there are non UTF-8 documents
> in the haystack (even if JIT is available)
> * git grep -P '^([/](?!/)|[^/])*~/.*' will now fail with a cryptic
> PCRE error instead of succeeding (but at least will be consistent and
> show the same error with PCRE2)

Thanks.  This was exactly the kind of thing I wanted to hear when I
asked if ab/pcre-jit-fixes is a good base to further build on.

As far as I am concerned, ab/pcre-jit-fixes and anything pcre that
are still in flight are fair game for a reboot during this cycle (I
hope I did not merge any of them to 'next' by mistake yet).  If
there are bad apples queued on 'pu', let's make sure we eject them
and rethink the way to address the issue(s) they wanted to address.


      reply	other threads:[~2019-08-27 19:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-18 20:17 [PATCH] grep: under --debug, show whether PCRE JIT is enabled Beat Bolli
2019-08-19 22:23 ` Junio C Hamano
2019-08-24 12:57   ` Carlo Arenas
2019-08-26 14:28     ` Johannes Schindelin
2019-08-26 14:42       ` Carlo Arenas
2019-08-26 16:02         ` Junio C Hamano
2019-08-26 16:36           ` Carlo Arenas
2019-08-27 19:43             ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzhju2y4b.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=carenas@gmail.com \
    --cc=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).