From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Damien Robert <damien.olivier.robert@gmail.com>,
git@vger.kernel.org,
Damien Robert <damien.olivier.robert+git@gmail.com>,
Derrick Stolee <dstolee@microsoft.com>,
William Baker <William.Baker@microsoft.com>
Subject: Re: [PATCH 1/1] midx.c: fix an integer overflow
Date: Fri, 28 Feb 2020 12:39:50 -0800 [thread overview]
Message-ID: <xmqqzhd2cup5.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200228185525.GB1408759@coredump.intra.peff.net> (Jeff King's message of "Fri, 28 Feb 2020 13:55:25 -0500")
Jeff King <peff@peff.net> writes:
>> - for (i = 0; i < m->num_objects - 1; i++) {
>> + for (i = 0; i + 1 < m->num_objects; i++) {
>> struct object_id oid1, oid2;
>>
>> nth_midxed_object_oid(&oid1, m, i);
> [...] nth_midxed_object_oid(&oid2, m, i + 1);
>
> Perhaps it would be simpler as:
>
> for (i = 1; i < m->num_objects; i++) {
> ...
> nth_midxed_object_oid(&oid1, m, i - 1);
> nth_midxed_object_oid(&oid2, m, i);
> ...
> }
"Count up while i+1 is smaller than..." looked extremely unnatural and
it was hard to grok, at least to me. This
for (i = 0; i < m->num_objects - 1; i++) {
might have been more palatable, but yours is much better.
> Though I almost wonder if we should be catching "m->num_objects == 0"
> early and declaring the midx to be bogus (it's not _technically_ wrong,
> but I'd have to suspect a bug in anything that generated a 0-object midx
> file).
That, too ;-)
next prev parent reply other threads:[~2020-02-28 20:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 16:24 [PATCH 1/1] midx.c: fix an integer overflow Damien Robert
2020-02-28 18:55 ` Jeff King
2020-02-28 20:39 ` Junio C Hamano [this message]
2020-02-29 17:15 ` Damien Robert
2020-02-29 15:38 ` Damien Robert
2020-03-12 17:35 ` [PATCH v2 " Damien Robert
2020-03-12 18:24 ` Damien Robert
2020-03-12 18:28 ` Derrick Stolee
2020-03-12 21:41 ` Damien Robert
2020-03-23 22:25 ` [PATCH v3 " Damien Robert
2020-03-24 6:01 ` Jeff King
2020-03-24 18:48 ` Junio C Hamano
2020-03-26 21:35 ` [PATCH v4 " Damien Robert
2020-03-26 23:27 ` Junio C Hamano
2020-03-28 22:23 ` Damien Robert
2020-03-28 23:51 ` Junio C Hamano
2020-03-28 22:18 ` [PATCH 1/1] midx.c: fix an integer underflow Damien Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzhd2cup5.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=William.Baker@microsoft.com \
--cc=damien.olivier.robert+git@gmail.com \
--cc=damien.olivier.robert@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).