From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] mingw: allow hooks to be .exe files
Date: Wed, 25 Jan 2017 13:39:44 -0800 [thread overview]
Message-ID: <xmqqy3xy95un.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170125211529.jq4halip4ndbff5k@sigill.intra.peff.net> (Jeff King's message of "Wed, 25 Jan 2017 16:15:30 -0500")
Jeff King <peff@peff.net> writes:
> On Wed, Jan 25, 2017 at 05:58:42PM +0100, Johannes Schindelin wrote:
>
>> This change is necessary to allow the files in .git/hooks/ to optionally
>> have the file extension `.exe` on Windows, as the file names are
>> hardcoded otherwise.
>
> Make sense as a goal.
>
>> - if (access(path.buf, X_OK) < 0)
>> + if (access(path.buf, X_OK) < 0) {
>> +#ifdef STRIP_EXTENSION
>> + strbuf_addstr(&path, ".exe");
>
> I think STRIP_EXTENSION is a string. Should this line be:
>
> strbuf_addstr(&path, STRIP_EXTENSION);
>
> ?
Yup, I think that is more in line with how git.c (the other user of
the macro) uses it.
next prev parent reply other threads:[~2017-01-25 21:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 16:58 [PATCH] mingw: allow hooks to be .exe files Johannes Schindelin
2017-01-25 21:15 ` Jeff King
2017-01-25 21:39 ` Junio C Hamano [this message]
2017-01-26 12:21 ` Johannes Schindelin
2017-01-26 18:44 ` Junio C Hamano
2017-01-27 10:29 ` Johannes Schindelin
2017-01-27 18:24 ` Stefan Beller
2017-01-30 12:29 ` Johannes Schindelin
2017-01-25 21:39 ` Junio C Hamano
2017-01-26 13:45 ` Johannes Schindelin
2017-01-26 12:21 ` [PATCH v2] " Johannes Schindelin
2017-01-30 12:28 ` [PATCH v3] " Johannes Schindelin
2017-01-30 16:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy3xy95un.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).