From: Junio C Hamano <gitster@pobox.com>
To: Fernando Ramos <greenfoo@u92.eu>
Cc: David Aguilar <davvid@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Seth House <seth@eseth.com>,
levraiphilippeblain@gmail.com, rogi@skylittlesystem.org
Subject: Re: [RFC PATCH] mergetools/vimdiff: add vimdiff4 merge tool variant
Date: Wed, 27 Oct 2021 09:46:56 -0700 [thread overview]
Message-ID: <xmqqy26ewh33.fsf@gitster.g> (raw)
In-Reply-To: <YXcP6kf3tGr+WFRS@zacax395.localdomain> (Fernando Ramos's message of "Mon, 25 Oct 2021 22:13:30 +0200")
Fernando Ramos <greenfoo@u92.eu> writes:
> The nice thing about this approach is that, as we have seen, it is generic
> enough to rule all current variants obsolete.
I am not a vimdiff user (or mergetools in general---I should use it
as appropriately from time to time myself), but it would be great if
such a general "layout rule language" can be used to replicate the
existing variants.
> So, please let me know what you think about this:
>
> * Do you like this approach? Or am I trying to crack a nut with a sledgehammer
> by making the whole thing too complex?
>
> * In case you like it, should we keep the old "vimdiff1", "vimdiff2" and
> "vimdiff3" variants for backwards compatibility?
> If the answer is "yes", I'll just alias them to the new "layout" mechanism
> so that the amount of extra code needed for supporting them is minimal.
It is great that the new "description based layout" can replicate
the existing variants, and it is natural migration path to redo the
existing variants with the new mechanism once the dust settles as a
separate step. The end-users should be able to rely on their
existing configuration to keep working the same way as they are used
to.
Thanks.
prev parent reply other threads:[~2021-10-27 16:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 21:20 [RFC PATCH] mergetools/vimdiff: add vimdiff4 merge tool variant Fernando Ramos
2021-10-19 22:12 ` Fernando Ramos
2021-10-24 22:54 ` David Aguilar
2021-10-25 18:18 ` Junio C Hamano
2021-10-25 20:13 ` Fernando Ramos
2021-10-27 16:46 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy26ewh33.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=greenfoo@u92.eu \
--cc=levraiphilippeblain@gmail.com \
--cc=rogi@skylittlesystem.org \
--cc=seth@eseth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).