From: Junio C Hamano <gitster@pobox.com>
To: Lucas Oshiro <lucasseikioshiro@gmail.com>
Cc: git@vger.kernel.org, kernel-usp@googlegroups.com,
rcdailey.lists@gmail.com, me@ttaylorr.com, peff@peff.net,
matheus.bernardino@usp.br
Subject: Re: [RFC WIP PATCH 0/3] tag: fix --edit and --no-edit flags
Date: Thu, 10 Oct 2019 11:13:26 +0900 [thread overview]
Message-ID: <xmqqwoddjqk9.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191008184727.14337-1-lucasseikioshiro@gmail.com> (Lucas Oshiro's message of "Tue, 8 Oct 2019 15:47:24 -0300")
Lucas Oshiro <lucasseikioshiro@gmail.com> writes:
> This series of patches fixes the flags --edit and --no-edit. Currently,
> --no-edit has no effect.
>
> These patches implement the following behaviour:
>
> - when --edit is provided, the editor will always be opened;
>
> - when --no-edit is provided, the editor will not be opened (if possible),
> otherwise an error message will be displayed;
>
> - when neither --edit nor --no-edit are provided, the editor is opened only if
> a message is not provided and there isn't a previous tag message.
Another thing that must be done is
- when both --edit and --no-edit are given, the last one wins.
I do not know if you have implemented it in the three patches, though.
> In the future, the fix of these flags and the code factoring done in this
> patchset will be used on the implementation of a new flag --amend, as discussed
> on the mail thread started on
> https://public-inbox.org/git/CAHd499BM6M+=zRE1WFVXr7b+VhJHFeDind5xLqXcwZLv7QeDvw@mail.gmail.com/.
>
> Lucas Oshiro (3):
> tag: factor out tag reading from write_tag_body()
> tag: factor out prepare tag template code
> tag: add full support for --edit and --no-edit
>
> builtin/tag.c | 123 ++++++++++++++++++++++++++++++++++---------------
> t/t7004-tag.sh | 4 +-
> 2 files changed, 88 insertions(+), 39 deletions(-)
prev parent reply other threads:[~2019-10-10 2:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 18:47 [RFC WIP PATCH 0/3] tag: fix --edit and --no-edit flags Lucas Oshiro
2019-10-08 18:47 ` [RFC WIP PATCH 1/3] tag: factor out tag reading from write_tag_body() Lucas Oshiro
2019-10-09 1:48 ` Matheus Tavares Bernardino
2019-10-10 2:42 ` Junio C Hamano
2019-10-08 18:47 ` [RFC WIP PATCH 2/3] tag: factor out prepare tag template code Lucas Oshiro
2019-10-09 3:02 ` Matheus Tavares Bernardino
2019-10-10 2:51 ` Junio C Hamano
2019-10-10 4:29 ` Junio C Hamano
2019-10-08 18:47 ` [RFC WIP PATCH 3/3] tag: add full support for --edit and --no-edit Lucas Oshiro
2019-10-09 9:19 ` Matheus Tavares Bernardino
2019-10-10 3:34 ` Junio C Hamano
2019-10-10 2:13 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwoddjqk9.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kernel-usp@googlegroups.com \
--cc=lucasseikioshiro@gmail.com \
--cc=matheus.bernardino@usp.br \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=rcdailey.lists@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).