From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id AE18E1FF40 for ; Wed, 30 Nov 2016 20:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755371AbcK3Uka (ORCPT ); Wed, 30 Nov 2016 15:40:30 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:57523 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752789AbcK3Uk2 (ORCPT ); Wed, 30 Nov 2016 15:40:28 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 6B98152E2A; Wed, 30 Nov 2016 15:40:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=/fI6A0RCU171M8US3gOg360AJrs=; b=xCboq3 CEs0syMwjJ7eWiw4NZtRQLBr7b2wZbQsU2S/eEHNQnESoSTTssWzGW935xBaXpKW +FtprNr6p/t/2H0/ouoxzBSwvuHJlrLU0EKa2xWpTRQcCb6yuJjJM5S+RMYlyZkY K8e4PxLnmKhzwgYi//+FnFuU5hgbKuEckYpvQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=PWBMcOk8+LyTcEtMMmRbb2qhHn5JYlei xyooa1dwYr9Z2AMtGODBmOwGJ7+QKm/uqQYjT/honJ8NyA47JG1WlwExmKAgp4hY TlGzv5sg/UFzpowysrKHg+ZupUix/vsfP4PDUbXGlXOcbHYr2ndwfB8PdVPY+LgQ 7zBGpxuUubs= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 6230752E29; Wed, 30 Nov 2016 15:40:27 -0500 (EST) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id AE51F52E28; Wed, 30 Nov 2016 15:40:26 -0500 (EST) From: Junio C Hamano To: Ramsay Jones Cc: Johannes Schindelin , GIT Mailing-list Subject: Re: [PATCH] difftool.c: mark a file-local symbol with static References: <4ddad7ea-5ac8-20b2-da9e-5843c486878a@ramsayjones.plus.com> <29abc89b-9ca5-930f-8e90-ca446ac2b96a@ramsayjones.plus.com> Date: Wed, 30 Nov 2016 12:40:25 -0800 In-Reply-To: <29abc89b-9ca5-930f-8e90-ca446ac2b96a@ramsayjones.plus.com> (Ramsay Jones's message of "Wed, 30 Nov 2016 19:57:18 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 39856F72-B73D-11E6-941F-B2917B1B28F4-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Ramsay Jones writes: > [I have fixed my config.mak file now, so I don't see the warning > anymore! Having -Wno-format-zero-length in DEVELOPER_CFLAGS, or > not, is a separate matter.] I suspect that 658df95a4a ("add DEVELOPER makefile knob to check for acknowledged warnings", 2016-02-25) took it from me (namely, Make script in my 'todo' branch). In turn, I added it to my set of flags in order to squelch this exact warning, so...