From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 1ED441F9FC for ; Mon, 22 Mar 2021 19:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231307AbhCVTWg (ORCPT ); Mon, 22 Mar 2021 15:22:36 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:56085 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231765AbhCVTWK (ORCPT ); Mon, 22 Mar 2021 15:22:10 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id E4D551181EE; Mon, 22 Mar 2021 15:22:09 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=nHhkHWfw5tQT oWzlnynDUwROzQo=; b=FFASjuwe+Nj6690nLbF3cKU+g59AgZ/lFbX7rNaMdrUK xlmmfxT6BJprU2JHLIFS2cqaQJWOVoPoI2dqUTJwMmFr7ByV3wKtojhJcKgHFgIG /NSfdLyVCZCE0FUonxwP0yha8/SS6CKD+DFjXkrv/3x4MG1rPnUq5vZjdHICZwY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=DmTGUB h7KCQeQnEBtj5GjXV8KeycEXEuJY34sAkr1vwltb/ao3SvR1q7E9e+LC7/LWvm68 SBjy+xnRX+6bM2/pmNGNsm8VC4a+MMmUqlo9R8vEJoXWvZlbRAwwafM3Jp0iMQCL 5Mk0zhIGuXreXpxCvZqvdcEzajj+ECDNF+MxQ= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id DD2511181ED; Mon, 22 Mar 2021 15:22:09 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 2E74D1181EA; Mon, 22 Mar 2021 15:22:07 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Ramsay Jones Subject: Re: [PATCH v2 2/2] diff --no-index tests: test mode normalization References: Date: Mon, 22 Mar 2021 12:22:05 -0700 In-Reply-To: (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Sun, 21 Mar 2021 23:36:20 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: E42B878E-8B43-11EB-9FA7-E43E2BB96649-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > +test_expect_success POSIXPERM,SYMLINKS 'diff --no-index normalizes: mo= de not like git mode (symlink)' ' > + ln -s y z && > + X_OID=3D$(git hash-object --stdin + Z_OID=3D$(echo -n y | git hash-object --stdin) && s/echo -n/printf/ t4053-diff-no-index.sh:185: error: echo with option is not portable (use printf): Z_OID=3D$(echo -n y | git hash-object --stdin) && gmake[1]: *** [Makefile:95: test-lint-shell-syntax] Error 1 gmake[1]: Leaving directory '/home/jch/w/buildfarm/jch/t' gmake: *** [Makefile:2855: test] Error 2