git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Osipov\, Michael" <michael.osipov@siemens.com>
Cc: Ævar Arnfjörð Bjarmason <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] configure: Detect linking style for HP aCC on HP-UX
Date: Fri, 07 Jun 2019 10:03:45 -0700
Message-ID: <xmqqr285pbta.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <c12ec5ff-87c9-a6d0-e9f6-6d7e1cf343c5@siemens.com>

"Osipov, Michael" <michael.osipov@siemens.com> writes:

> Am 2019-05-16 um 11:34 schrieb Ævar Arnfjörð Bjarmason:
>> From: Michael Osipov <michael.osipov@siemens.com>
>>
>> HP aCC does not accept any of the previously tested CC_LD_DYNPATH
>> formats, but only its own[1] "-Wl,+b" format. Add it to configure.ac.
>>
>> 1. http://nixdoc.net/man-pages/hp-ux/man1/ld_pa.1.html
>>
>> Signed-off-by: Michael Osipov <michael.osipov@siemens.com>
>> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>> ---
>>
>> I took the liberty of slightly amending the commit message.
>>
>>   configure.ac | 14 ++++++++++++--
>>   1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index be3b55f1cc..a43b476402 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -475,8 +475,18 @@ else
>>         if test "$git_cv_ld_rpath" = "yes"; then
>>            CC_LD_DYNPATH=-rpath
>>         else
>> -         CC_LD_DYNPATH=
>> -         AC_MSG_WARN([linker does not support runtime path to dynamic libraries])
>> +         AC_CACHE_CHECK([if linker supports -Wl,+b,], git_cv_ld_wl_b, [
>> +            SAVE_LDFLAGS="${LDFLAGS}"
>> +            LDFLAGS="${SAVE_LDFLAGS} -Wl,+b,/"
>> +            AC_LINK_IFELSE([AC_LANG_PROGRAM([], [])], [git_cv_ld_wl_b=yes], [git_cv_ld_wl_b=no])
>> +            LDFLAGS="${SAVE_LDFLAGS}"
>> +         ])
>> +         if test "$git_cv_ld_wl_b" = "yes"; then
>> +            CC_LD_DYNPATH=-Wl,+b,
>> +          else
>> +             CC_LD_DYNPATH=
>> +             AC_MSG_WARN([linker does not support runtime path to dynamic libraries])
>> +          fi
>>         fi
>>      fi
>>   fi
>>
>
> I can see that this one has not yet been committed nor my PR has been
> pulled.
>
> Any chances to get this into master?
>
> Michael

Sorry, it jsut fell of the cracks.  The way the new test was added
looks very good --- any platform that is happy with the existing
test will continue to function the same way, and a platform that
knows -Wl,+b would use it instead of failing.

Will pick it up.

Thanks.

      reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 10:45 [PATCH] Improving HP-UX support Osipov, Michael
2019-05-09  7:32 ` Ævar Arnfjörð Bjarmason
2019-05-09  8:09   ` Osipov, Michael
2019-05-13 22:17     ` [PATCH] sha1dc: update from upstream Ævar Arnfjörð Bjarmason
2019-05-14 11:17       ` Osipov, Michael
2019-05-15 11:48         ` Ævar Arnfjörð Bjarmason
2019-05-16  7:13           ` Osipov, Michael
2019-05-16  8:31             ` Ævar Arnfjörð Bjarmason
2019-05-16  8:40               ` Osipov, Michael
2019-05-16  9:34             ` [PATCH] configure: Detect linking style for HP aCC on HP-UX Ævar Arnfjörð Bjarmason
2019-05-16 18:05               ` [PATCH] Makefile: remove the NO_R_TO_GCC_LINKER flag Ævar Arnfjörð Bjarmason
2019-05-16 22:25                 ` Jeff King
2019-05-16 23:21                   ` Junio C Hamano
2019-05-17  0:23                     ` Jeff King
2019-05-17 21:58                     ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2019-05-19  0:56                       ` Junio C Hamano
2019-05-19  5:01                       ` Jeff King
2019-06-07 14:51               ` [PATCH] configure: Detect linking style for HP aCC on HP-UX Osipov, Michael
2019-06-07 17:03                 ` Junio C Hamano [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr285pbta.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=michael.osipov@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror http://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox