From: Junio C Hamano <gitster@pobox.com>
To: "Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Hariom Verma <hariom18599@gmail.com>
Subject: Re: [PATCH 1/1] builtin/blame.c: constants into bit shift format
Date: Thu, 17 Oct 2019 16:38:48 +0900 [thread overview]
Message-ID: <xmqqr23b7ref.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <3b4b8e0353d705ea649c9fb608c021b35e6d8f5b.1571250635.git.gitgitgadget@gmail.com> (Hariom Verma via GitGitGadget's message of "Wed, 16 Oct 2019 18:30:35 +0000")
"Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com> writes:
> -#define OUTPUT_SHOW_AGE_WITH_COLOR 04000
> +#define OUTPUT_ANNOTATE_COMPAT (1<<0)
> +#define OUTPUT_LONG_OBJECT_NAME (1<<1)
> +#define OUTPUT_RAW_TIMESTAMP (1<<2)
> +#define OUTPUT_PORCELAIN (1<<3)
> +#define OUTPUT_SHOW_NAME (1<<4)
> +#define OUTPUT_SHOW_NUMBER (1<<5)
> +#define OUTPUT_SHOW_SCORE (1<<6)
> +#define OUTPUT_NO_AUTHOR (1<<7)
> +#define OUTPUT_SHOW_EMAIL (1<<8)
> +#define OUTPUT_LINE_PORCELAIN (1<<9)
> +#define OUTPUT_COLOR_LINE (1<<10)
> +#define OUTPUT_SHOW_AGE_WITH_COLOR (1<<11)
For these small shift counts it probably would not matter, but it
may be a good discipline to make sure they are treated as constants
of an unsigned type (i.e. write them as (1U<<0) etc.). It probably
starts to matter when you reach 1<<31 if these are bits stuffed into
"unsigned int" on 32-bit arch.
One advantage of octal and hexadecimal notations have is that
0x80000000 is automatically unsigned, IIRC, on such an archtecture.
next prev parent reply other threads:[~2019-10-17 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 18:30 [PATCH 0/1] builtin/blame.c: bit field constants into bit shift format Hariom Verma via GitGitGadget
2019-10-16 18:30 ` [PATCH 1/1] builtin/blame.c: " Hariom Verma via GitGitGadget
2019-10-16 19:10 ` Pratyush Yadav
2019-10-16 19:37 ` Jonathan Tan
2019-10-16 19:44 ` Pratyush Yadav
2019-10-17 7:38 ` Junio C Hamano [this message]
2019-10-17 7:33 ` [PATCH 0/1] builtin/blame.c: bit field " Junio C Hamano
2019-10-17 17:46 ` [PATCH v2 " Hariom Verma via GitGitGadget
2019-10-17 17:46 ` [PATCH v2 1/1] builtin/blame.c: " Hariom Verma via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr23b7ref.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hariom18599@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).