From: Junio C Hamano <email@example.com> To: Jonathan Tan <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH] send-pack: use OBJECT_INFO_QUICK to check negative objects Date: Wed, 04 Dec 2019 13:37:41 -0800 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> (Jonathan Tan's message of "Wed, 4 Dec 2019 12:53:53 -0800") Jonathan Tan <firstname.lastname@example.org> writes: > As for whether we should do it in the first place, I think that having 2 > orthogonal flags is clearer than having 1 that controls fetch > (SKIP_FETCH) and 1 that does both (QUICK) without any that recheck > packed, but I'm quite familiar with this part of the code, so perhaps > I'm the wrong person to ask - we should optimize for the typical Git > developer who just wants to access the object store. Judging from the > frequency in which we encounter this issue (as Peff says), maybe we > should go ahead and make QUICK imply SKIP_FETCH but not the other way > around. Thanks for thinking this through. I am OK with that direction. > (It is also possible just to make both imply the other and unify > QUICK and SKIP_FETCH into one flag - I am not opposed to that - > although read my email that Peff linked to see why bidirectional > implication is correct in one sense but incorrect in another.) Yup, also from the old message: > Having said that, perhaps we should consider promisor-remote.c as > low-level code and expect it to know that objects are fetched into a > packfile (as opposed to loose objects), so it can safely use QUICK > (which is documented as checking packed after packed and loose). If no > one disagrees, I can make such a patch after jt/push-avoid-lazy-fetch is > merged to master (as is the plan, according to What's Cooking ). I agree that it makes sense to treat promisor-remote.c as the low-level implementation detail that is allowed to be intimately familiar with how its behaviour would interact with QUICK and SKIP_FETCH options. Thanks.
next prev parent reply index Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-19 13:12 Push a ref to a remote with many refs Patrick Marlier (pamarlie) 2019-11-25 16:22 ` Patrick Marlier (pamarlie) 2019-11-27 12:32 ` [PATCH] send-pack: use OBJECT_INFO_QUICK to check negative objects Jeff King 2019-11-29 9:22 ` Patrick Marlier (pamarlie) 2019-11-30 17:08 ` Junio C Hamano 2019-12-03 23:20 ` Jeff King 2019-12-04 20:53 ` Jonathan Tan 2019-12-04 21:37 ` Junio C Hamano [this message] 2019-12-04 3:55 ` Jonathan Nieder 2019-12-04 4:05 ` Jeff King 2019-12-10 16:16 ` Patrick Marlier (pamarlie) 2019-12-10 20:27 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
email@example.com list mirror (unofficial, one of many) Archives are clonable: git clone --mirror http://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Example config snippet for mirrors Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ AGPL code for this site: git clone https://public-inbox.org/public-inbox.git