git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Sibi Siddharthan <sibisiv.siddharthan@gmail.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Aug 2020, #01; Mon, 3)
Date: Tue, 04 Aug 2020 11:58:43 -0700	[thread overview]
Message-ID: <xmqqr1sms0f0.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200804185057.GA1400256@coredump.intra.peff.net> (Jeff King's message of "Tue, 4 Aug 2020 14:50:57 -0400")

Jeff King <peff@peff.net> writes:

> On Mon, Aug 03, 2020 at 10:35:40PM -0700, Junio C Hamano wrote:
>
>> * ss/cmake-build (2020-06-26) 8 commits
>>   (merged to 'next' on 2020-08-03 at a0d70165c1)
>>  + ci: modification of main.yml to use cmake for vs-build job
>>  + cmake: support for building git on windows with msvc and clang.
>>  + cmake: support for building git on windows with mingw
>>  + cmake: support for testing git when building out of the source tree
>>  + cmake: support for testing git with ctest
>>  + cmake: installation support for git
>>  + cmake: generate the shell/perl/python scripts and templates, translations
>>  + Introduce CMake support for configuring Git
>> 
>>  Originally merged to 'next' on 2020-08-01
>> 
>>  CMake support to build with MSVC for Windows bypassing the Makefile.
>> 
>>  Will merge to 'master'.
>>  cf. https://github.com/git/git/runs/892824895
>
> I ran into issues with this, as I have several in-progress topics (not
> yet sent to the list) that touch our Makefile, and they needed updates
> to the cmake file (because it reproduces a lot of the lists and logic
> from the Makefile).
>
> The original philosophy behind putting it in contrib is that most people
> wouldn't have to care, and folks interested in cmake would be
> responsible for keeping it up to date. But the top patch makes it hard
> to ignore, because the vs-build CI job will fail.
>
> I'm not sure of the right path forward. I was definitely unenthused to
> be dealing with cmake, and the problem came up as soon as the series hit
> next.

My hope is that if we let vs-build broken long enough, those who
want to see cmake to graduate would fix it.  We can always threaten
the topic to be discarded out of 'next' after the next release if it
hasn't been fixed ;-)

  reply	other threads:[~2020-08-04 18:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04  5:35 What's cooking in git.git (Aug 2020, #01; Mon, 3) Junio C Hamano
2020-08-04 18:50 ` Jeff King
2020-08-04 18:58   ` Junio C Hamano [this message]
2020-08-04 19:20     ` Jeff King
2020-08-12 13:35       ` Johannes Schindelin
2020-08-12 14:19         ` Jeff King
2020-08-12 15:56           ` Sibi Siddharthan
2020-08-12 16:06             ` Jeff King
2020-08-12 19:53               ` Junio C Hamano
2020-08-12 20:11                 ` Jeff King
2020-08-14 12:08               ` Johannes Schindelin
2020-08-14 12:40                 ` Jeff King
2020-08-17  4:41                   ` Johannes Schindelin
2020-08-17 17:19                   ` Junio C Hamano
2020-08-06  3:25 ` Jiang Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr1sms0f0.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sibisiv.siddharthan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).