From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id F206D20986 for ; Wed, 19 Oct 2016 19:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943538AbcJSTYQ (ORCPT ); Wed, 19 Oct 2016 15:24:16 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:52985 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S942545AbcJSTYP (ORCPT ); Wed, 19 Oct 2016 15:24:15 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id E0FFE47FC4; Wed, 19 Oct 2016 15:24:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=aKDwt/vdAeuZmzbe7NERAhgFQtM=; b=tj1vrW OfcN/menJacsk5GecgBRpFhQErurwHBnPM6SWrt1Ps1vJKu3pFx+9IZEZcfiglC0 N9xKEXzV+FELQsn0513cnDpVYdhlc4IWUFbvew6Zuo/Kp6C4VH4X+frodbT3UuC7 p7ARsAVqEqIAm3fGZZ9VA5bF1BirV/F5mkkf4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=nyC4Xd+8As5bSxY0oeCSOpLVNXD+ha9d L8ZN0SRW33yepnphulvyAf2Lcof7nWbuo6CAqUftqGwnIH1NV92wqNRm4daAWZz9 mXL6Lth5eSj7ATHAH8U/NlBTnvDi8LdQByZIUfvEnr7GEBWx6XqPk7yC/KVeYYrl HXj2va0NZJI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id D8FA147FC3; Wed, 19 Oct 2016 15:24:13 -0400 (EDT) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 4AE2F47FC2; Wed, 19 Oct 2016 15:24:13 -0400 (EDT) From: Junio C Hamano To: Jonathan Tan Cc: Stefan Beller , "git\@vger.kernel.org" , Jakub =?utf-8?Q?Nar=C4=99bski?= Subject: Re: [PATCH v3 5/6] trailer: allow non-trailers in trailer block References: <1b3fe84e4b6126884a801e721d0a93c41fcb4184.1476466609.git.jonathantanmy@google.com> <31cae41d-701c-c657-f04e-3b617c0b1d39@google.com> Date: Wed, 19 Oct 2016 12:24:11 -0700 In-Reply-To: <31cae41d-701c-c657-f04e-3b617c0b1d39@google.com> (Jonathan Tan's message of "Wed, 19 Oct 2016 11:00:45 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 9E351E18-9631-11E6-BDAC-987C12518317-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jonathan Tan writes: > Would this work then: > - at least one trailer line generated by Git ("(cherry picked by" or > "Signed-off-by: ") or configured in the "trailer" section in > git config AND at least 25% logical trailer lines > OR > - 100% logical trailer lines Sure. At that point, I doubt that the latter "100% logical trailer" makes much difference, though, because at least one of them is likely to be in the former set, or the users can easily make it so by throwing what they use like "Bug: ", "Test: " and "Change-ID: " in the "configured in the trailer section" category. FWIW, I do not think we mind terribly to tweak the definition of "generated by Git" class to "commonly used in Git managed projects" to include "Change-ID:" and friends.