From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 858681F4B4 for ; Wed, 21 Oct 2020 21:24:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2506075AbgJUVYZ (ORCPT ); Wed, 21 Oct 2020 17:24:25 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:58622 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440933AbgJUVYY (ORCPT ); Wed, 21 Oct 2020 17:24:24 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id A2FC190832; Wed, 21 Oct 2020 17:24:23 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=YxDjAxPF4fWtgEBD/6eHDXVf+hg=; b=KJKwij WRzYMIQgHm8292WqPxKVBKrTb6s+agZA5N7SYsDGrM8BsUNRmfvtfVxjSElBKXNZ IH4rEIm9VJa2RGkX3fNFa+HJMp8bYpNNzUUPDzEZPaGRRcChuXYvs6sj20BmGX/2 WrS0oTahBhvu9yTvBuz2Jxm7zEZk2F5oo02to= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=NN4BH13r6cxVgEwZYdN0/YYaLrZ7ZZHa 5sYVZWNA1wRJBcgBIGmRwnmaxNFYzQr8ES49YU2ai5vQsPakhNg+zO+tbaBVj3R6 pSapCAe9qYRZOoKvxbbJYDm4OC6sNEotZm+0Sa3GVuQfJkQyA74t03YDo4QOA+FD xqs22mJlJFY= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 992D490831; Wed, 21 Oct 2020 17:24:23 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 2B46390830; Wed, 21 Oct 2020 17:24:23 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Taylor Blau Cc: Alex Vandiver via GitGitGadget , git@vger.kernel.org, Nipunn Koorapati , Alex Vandiver Subject: Re: [PATCH 1/2] fsmonitor: stop inline'ing mark_fsmonitor_valid / _invalid References: <049989652cefb90304e711dbfe354b55a5a71f41.1603303474.git.gitgitgadget@gmail.com> <20201021205537.GB1270359@nand.local> Date: Wed, 21 Oct 2020 14:24:22 -0700 In-Reply-To: <20201021205537.GB1270359@nand.local> (Taylor Blau's message of "Wed, 21 Oct 2020 16:55:37 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: C9F82386-13E3-11EB-BE4A-D152C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Taylor Blau writes: >> +extern void mark_fsmonitor_invalid(struct index_state *istate, struct cache_entry *ce); > ... > Any reason that these need to be externed explicitly? Note that these > functions are already externed by default since you haven't said > otherwise (and for no other reason than this'd be the only explicitly > externed function in fsmonitor.h). Possibly due to the recent discussion? https://lore.kernel.org/git/xmqqtuv3ryhr.fsf_-_@gitster.c.googlers.com/