git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kalyan Sriram" <kalyan@coderkalyan.com>
Cc: "Matheus Tavares" <matheus.bernardino@usp.br>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	"git" <git@vger.kernel.org>
Subject: Re: Git submodule remove
Date: Sun, 24 Oct 2021 13:46:45 -0700	[thread overview]
Message-ID: <xmqqo87e40cq.fsf@gitster.g> (raw)
In-Reply-To: <0101017cb4026947-7e22d019-674b-4d1c-b229-b10328252341-000000@us-west-2.amazonses.com> (Kalyan Sriram's message of "Sun, 24 Oct 2021 20:33:49 +0000")

"Kalyan Sriram" <kalyan@coderkalyan.com> writes:

>> So "git rm" seems to be doing exactly what "git submodule rm" should
>> be doing, nothing more, nothing less.
>
> That makes sense, thanks for the clarification. So it looks like there
> isn't any work to be done here after all?
>
> What are your thoughts about aliasing git submodule rm to git rm? 

It is unfortunate that "git rm" learned these "extra" things that
are integral part of "submodule removal" if you believe that the way
"submodules" are handled in the current "git submodule"-style design
is the only thing all Git users must follow.

Unless we plan to eventually make "git rm" unlearn these hardcoded
'git submodule'-way actions it does (like editing the .gitmodules
file) and move them to "git submodule rm", I do not think it is
worth the engineering effort to add an alias so that "git submodule
rm" would be a synonym to the current "git rm".

Thanks.

  reply	other threads:[~2021-10-24 20:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 17:25 Git submodule remove Kalyan Sriram
2021-10-21 21:36 ` brian m. carlson
2021-10-21 22:47   ` Junio C Hamano
2021-10-21 23:25     ` Matheus Tavares
2021-10-21 23:35       ` Junio C Hamano
2021-10-22  3:32         ` Kalyan Sriram
2021-10-22 22:02           ` Junio C Hamano
2021-10-24 20:33             ` Kalyan Sriram
2021-10-24 20:46               ` Junio C Hamano [this message]
2021-10-22 12:12         ` Ævar Arnfjörð Bjarmason
2021-10-22 21:32           ` Junio C Hamano
2021-10-22 13:47     ` Randall S. Becker
2021-10-22 17:52       ` Kalyan Sriram
2021-10-22 20:45         ` Randall S. Becker
2021-10-22 21:17         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo87e40cq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kalyan@coderkalyan.com \
    --cc=matheus.bernardino@usp.br \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).