From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id DFD1F1F4D7 for ; Thu, 2 Jun 2022 17:48:22 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="V6PFpSaD"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237679AbiFBRsR (ORCPT ); Thu, 2 Jun 2022 13:48:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236902AbiFBRsQ (ORCPT ); Thu, 2 Jun 2022 13:48:16 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBD9ADF90 for ; Thu, 2 Jun 2022 10:48:14 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 3C49E18F7F5; Thu, 2 Jun 2022 13:48:14 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=AsRk13Hr2IbnlXAMdEQlklUiPBLOwtLYCGlIKY Afuek=; b=V6PFpSaDU0zGKoL8t0UJuiVrXTsgJQGU2SsxIXd0YElTKADYNbPrdo wXLXKJNPscK1NLeyZQnVbwY88XMeROWS5MbFkzhoU+K3D7qN7Ybwyaj+I2untvHd xoeoT25Yph9Vwm7tKiqM+lfouGh4nm9bWB71EB9CBEwFoVeKFqBzk= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 3434F18F7F2; Thu, 2 Jun 2022 13:48:14 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.92.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id B16D918F7F0; Thu, 2 Jun 2022 13:48:10 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Johannes Schindelin Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , git@vger.kernel.org, Josh Steadmon , congdanhqx@gmail.com, dyroneteng@gmail.com, martin.agren@gmail.com, peff@peff.net, tenglong.tl@alibaba-inc.com Subject: Re: [PATCH] ls-tree: test for the regression in 9c4d58ff2c3 References: Date: Thu, 02 Jun 2022 10:48:09 -0700 In-Reply-To: (Johannes Schindelin's message of "Thu, 2 Jun 2022 17:18:13 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 2B17C3E6-E29C-11EC-BE2A-CBA7845BAAA9-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Johannes Schindelin writes: >> +test_ls_tree_format_mode_output () { >> + local opts=$1 && > > This line does not quote `$1`, but... > > ... this line passes a first argument that contains spaces. Hence the > tests fail in CI: > https://github.com/git/git/runs/6703333447?check_suite_focus=true We had a portability discussion not so in distant past on "local". https://lore.kernel.org/git/xmqqsftc3nd6.fsf@gitster.g/ The conclusion from the thread IIRC is * Very safe local var; var=$1 * Probably OK local var="$1" * Not portable local var=$1 Thanks.