git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org,  chris.torek@gmail.com
Subject: Re: [PATCH 1/2] update-ref: use {old,new}-oid instead of {old,new}value
Date: Mon, 01 Apr 2024 13:51:46 -0700	[thread overview]
Message-ID: <xmqqo7as957h.fsf@gitster.g> (raw)
In-Reply-To: <20240401144542.88027-2-knayak@gitlab.com> (Karthik Nayak's message of "Mon, 1 Apr 2024 16:45:41 +0200")

Karthik Nayak <karthik.188@gmail.com> writes:

> From: Karthik Nayak <karthik.188@gmail.com>
>
> The `git-update-ref` command is used to modify references. The usage of
> {old,new}value in the documentation refers to the OIDs. This is fine
> since the command only works with regular references which hold OIDs.
> But if the command is updated to support symrefs, we'd also be dealing
> with {old,new}-refs.
>
> To improve clarity around what exactly {old,new}value mean, let's rename
> it to {old,new}-oid.
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
>  Documentation/git-update-ref.txt | 58 ++++++++++++++++----------------
>  builtin/update-ref.c             | 26 +++++++-------
>  2 files changed, 42 insertions(+), 42 deletions(-)

Did you run t1400 after this update?  There may be other tests that
the message update is breaking but that was the first one I noticed.


  reply	other threads:[~2024-04-01 20:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01 14:45 [PATCH 0/2] improve documentation around git-update-ref Karthik Nayak
2024-04-01 14:45 ` [PATCH 1/2] update-ref: use {old,new}-oid instead of {old,new}value Karthik Nayak
2024-04-01 20:51   ` Junio C Hamano [this message]
2024-04-01 22:38     ` Karthik Nayak
2024-04-01 23:00       ` Junio C Hamano
2024-04-02  6:50         ` Karthik Nayak
2024-04-01 14:45 ` [PATCH 2/2] githooks: use {old,new}-oid instead of {old,new}-value Karthik Nayak
2024-04-02  6:49 ` [PATCH v2 0/2] improve documentation around git-update-ref Karthik Nayak
2024-04-02  6:49   ` [PATCH v2 1/2] update-ref: use {old,new}-oid instead of {old,new}value Karthik Nayak
2024-04-02  6:49   ` [PATCH v2 2/2] githooks: use {old,new}-oid instead of {old,new}-value Karthik Nayak
2024-04-02  6:56   ` [PATCH v2 0/2] improve documentation around git-update-ref Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo7as957h.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chris.torek@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).