git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Roland Hieber <rhi@pengutronix.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] completion: add docs on how to add subcommand completions
Date: Wed, 24 Apr 2024 15:22:32 -0700	[thread overview]
Message-ID: <xmqqo79ywgd3.fsf@gitster.g> (raw)
In-Reply-To: <20240424210549.256256-2-rhi@pengutronix.de> (Roland Hieber's message of "Wed, 24 Apr 2024 23:05:48 +0200")

Roland Hieber <rhi@pengutronix.de> writes:

> It took me more than a few tries and a good lecture of __git_main to
> understand that the two paragraphs above really only refer to adding
> completion functions for executables that are not called through git's
> subcommand magic. Add a few sentences for that case.

OK.  Perhaps the two examples also need some more explanation to
save the next person from wasting their time figuring out what they
are trying to say?  That would be a separate topic, but it would be
nice to fix it while our minds are fresh on that issue.

As I already said, modulo confusion around "-my", the patch looks
good to me.

Thanks.


      parent reply	other threads:[~2024-04-24 22:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 21:05 [PATCH 1/2] completion: add 'symbolic-ref' Roland Hieber
2024-04-24 21:05 ` [PATCH 2/2] completion: add docs on how to add subcommand completions Roland Hieber
2024-04-24 21:17   ` Roland Hieber
2024-04-24 21:36   ` Junio C Hamano
2024-04-24 21:41     ` Roland Hieber
2024-04-24 22:22   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo79ywgd3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).