git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Romuald Brunet <romuald@chivil.com>,
	git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@imag.fr>
Subject: Re: [PATCH] push: allow atomic flag via configuration
Date: Fri, 24 Mar 2017 12:29:50 -0700	[thread overview]
Message-ID: <xmqqmvca79sh.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170324184550.3l6mw4ybynizblsm@sigill.intra.peff.net> (Jeff King's message of "Fri, 24 Mar 2017 14:45:51 -0400")

Jeff King <peff@peff.net> writes:

> My one question would be whether people would want this to actually be
> specific to a particular remote, and not just on for a given repository
> (your "site-specific" in the description made me think of that). In that
> case it would be better as part of the remote.* config.

Yeah, I had the same reaction.  

Conceptually, this sits next to remote.*.push that defines which set
of refs are sent by default, and remote.<name>.pushAtomic does make
sense.  If (and only if) it turns out to be cumbersome for somebody
to set the configuration for each and every remote, it is OK to also
add push.atomic to serve as a fallback for remote.*.pushAtomic, I
would think, but adding only push.atomic feels somewhat backwards.




  parent reply	other threads:[~2017-03-24 19:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24 17:17 [PATCH] push: allow atomic flag via configuration Romuald Brunet
2017-03-24 18:45 ` Jeff King
2017-03-24 18:53   ` Jonathan Nieder
2017-03-24 19:01     ` Jeff King
2017-03-24 19:29   ` Junio C Hamano [this message]
2017-03-27  8:27     ` Romuald Brunet
2017-03-28  0:51       ` Jonathan Nieder
2017-03-27  9:30 ` Ævar Arnfjörð Bjarmason
2017-03-27  9:33 ` Ævar Arnfjörð Bjarmason
2017-03-27 16:59   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmvca79sh.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@imag.fr \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=romuald@chivil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).