From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: VenomVendor <info@venomvendor.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
git@vger.kernel.org
Subject: Re: committer-date-is-author-date flag removes email in "Commit"
Date: Fri, 23 Oct 2020 08:23:40 -0700 [thread overview]
Message-ID: <xmqqmu0dhsoz.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201023070747.GA2198273@coredump.intra.peff.net> (Jeff King's message of "Fri, 23 Oct 2020 03:07:47 -0400")
Jeff King <peff@peff.net> writes:
> On Fri, Oct 23, 2020 at 11:18:51AM +0530, VenomVendor wrote:
>
>> What did you do before the bug happened? (Steps to reproduce your issue)
>> * Create empty repo using `git init`
>> * Make few commits, at least two
>> * execute `git log --format=fuller`
>> * Notice the log, with "Author", "AuthorDate", "Commit", "CommitDate"
>> * Note, "Commit"
>> * execute `git rebase --committer-date-is-author-date HEAD~1`
>> * execute `git log --format=fuller`
>> * Note, email from "Commit" is empty <>
>
> Thanks for a clear report. I was able to easily reproduce the problem.
> There are actually two related bugs here, and they're both regressions
> in v2.29.0.
>
> [1/3]: t3436: check --committer-date-is-author-date result more carefully
> [2/3]: am: fix broken email with --committer-date-is-author-date
> [3/3]: rebase: fix broken email with --committer-date-is-author-date
Thanks for taking quick care of this. It counts as an embarrasing
brown-paper-bag bug; it is a bit surprising that nobody noticed it
while the original change was discussed.
I wonder if we even needed to do the original change to begin with
(stopping to export means not giving information to the hooks), but
that is a separate matter.
Will take a look and queue. Thanks.
>
> builtin/am.c | 4 ++--
> sequencer.c | 2 +-
> t/t3436-rebase-more-options.sh | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> -Peff
next prev parent reply other threads:[~2020-10-23 15:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 5:48 committer-date-is-author-date flag removes email in "Commit" VenomVendor
2020-10-23 7:07 ` Jeff King
2020-10-23 7:08 ` [PATCH 1/3] t3436: check --committer-date-is-author-date result more carefully Jeff King
2020-10-23 10:10 ` Phillip Wood
2020-10-23 7:09 ` [PATCH 2/3] am: fix broken email with --committer-date-is-author-date Jeff King
2020-10-23 7:26 ` [PATCH 4/3] am, sequencer: stop parsing our own committer ident Jeff King
2020-10-23 7:45 ` Jeff King
2020-10-23 17:29 ` Taylor Blau
2020-10-26 16:25 ` Johannes Schindelin
2020-10-27 7:23 ` Jeff King
2020-10-23 14:06 ` Phillip Wood
2020-10-26 17:12 ` Junio C Hamano
2020-10-27 7:24 ` Jeff King
2020-10-23 7:10 ` [PATCH 3/3] rebase: fix broken email with --committer-date-is-author-date Jeff King
2020-10-23 15:23 ` Junio C Hamano [this message]
2020-10-23 17:32 ` committer-date-is-author-date flag removes email in "Commit" Phillip Wood
2020-10-23 17:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmu0dhsoz.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=info@venomvendor.com \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).