From: Junio C Hamano <gitster@pobox.com>
To: David Aguilar <davvid@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] tag: add a config option for setting --annotate by default
Date: Fri, 03 Feb 2017 21:02:47 -0800 [thread overview]
Message-ID: <xmqqlgtm8s5k.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170204021402.15927-1-davvid@gmail.com> (David Aguilar's message of "Fri, 3 Feb 2017 18:14:02 -0800")
David Aguilar <davvid@gmail.com> writes:
> Make it easier for users to remember to annotate their tags.
> Allow setting the default value for "--annotate" via the "tag.annotate"
> configuration variable.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
I do not care too strongly about this, but I need to point out that
this will have fallout to tools and scripts. E.g. if you have this
configured and try to create a new tag in gitk, wouldn't this part
if {$msg != {}} {
exec git tag -a -m $msg $tag $id
} else {
exec git tag $tag $id
}
try to open an editor somehow to get the message even when $msg is
an empty string? I think the same problem already exists for the
tag.forceSignAnnotated variable we already have added, though.
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index af2ae4cc02..0d562b97e9 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2945,6 +2945,11 @@ submodule.alternateErrorStrategy
> as computed via `submodule.alternateLocation`. Possible values are
> `ignore`, `info`, `die`. Default is `die`.
>
> +tag.annotate::
> + A boolean to specify whether annotated tags should be created by
> + default. If `--no-annotate` is specified on the command line,
> + it takes precedence over this option.
> +
> tag.forceSignAnnotated::
> A boolean to specify whether annotated tags created should be GPG signed.
> If `--annotate` is specified on the command line, it takes
next prev parent reply other threads:[~2017-02-04 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 2:14 [PATCH] tag: add a config option for setting --annotate by default David Aguilar
2017-02-04 5:02 ` Junio C Hamano [this message]
2017-02-05 4:10 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgtm8s5k.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).